Commit 35a84f34 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'trace-v4.18-rc3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace 

Pull tracing fixlet from Steven Rostedt:
 "Joel Fernandes asked to add a feature in tracing that Android had its
  own patch internally for. I took it back in 4.13. Now he realizes that
  he had a mistake, and swapped the values from what Android had. This
  means that the old Android tools will break when using a new kernel
  that has the new feature on it.

  The options are:

   1. To swap it back to what Android wants.
   2. Add a command line option or something to do the swap
   3. Just let Android carry a patch that swaps it back

  Since it requires setting a tracing option to enable this anyway, I
  doubt there are other users of this than Android. Thus, I've decided
  to take option 1. If someone else is actually depending on the order
  that is in the kernel, then we will have to revert this change and go
  to option 2 or 3"

* tag 'trace-v4.18-rc3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
  tracing: Reorder display of TGID to be after PID
parents a0092e5e f8494fa3

kernel/trace/trace.c

+4 −4
Original line number Diff line number Diff line
@@ -3365,8 +3365,8 @@ static void print_func_help_header(struct trace_buffer *buf, struct seq_file *m, 


	print_event_info(buf, m);



	seq_printf(m, "#           TASK-PID   CPU#   %s  TIMESTAMP  FUNCTION\n", tgid ? "TGID     " : "");

	seq_printf(m, "#              | |       |    %s     |         |\n",	 tgid ? "  |      " : "");

	seq_printf(m, "#           TASK-PID   %s  CPU#   TIMESTAMP  FUNCTION\n", tgid ? "TGID     " : "");

	seq_printf(m, "#              | |     %s    |       |         |\n",	 tgid ? "  |      " : "");

}



static void print_func_help_header_irq(struct trace_buffer *buf, struct seq_file *m,
@@ -3386,9 +3386,9 @@ static void print_func_help_header_irq(struct trace_buffer *buf, struct seq_file 
		   tgid ? tgid_space : space);

	seq_printf(m, "#                          %s||| /     delay\n",

		   tgid ? tgid_space : space);

	seq_printf(m, "#           TASK-PID   CPU#%s||||    TIMESTAMP  FUNCTION\n",

	seq_printf(m, "#           TASK-PID %sCPU#  ||||    TIMESTAMP  FUNCTION\n",

		   tgid ? "   TGID   " : space);

	seq_printf(m, "#              | |       | %s||||       |         |\n",

	seq_printf(m, "#              | |   %s  |   ||||       |         |\n",

		   tgid ? "     |    " : space);

}

kernel/trace/trace_output.c

+3 −2
Original line number Diff line number Diff line
@@ -594,8 +594,7 @@ int trace_print_context(struct trace_iterator *iter) 


	trace_find_cmdline(entry->pid, comm);



	trace_seq_printf(s, "%16s-%-5d [%03d] ",

			       comm, entry->pid, iter->cpu);

	trace_seq_printf(s, "%16s-%-5d ", comm, entry->pid);



	if (tr->trace_flags & TRACE_ITER_RECORD_TGID) {

		unsigned int tgid = trace_find_tgid(entry->pid);
@@ -606,6 +605,8 @@ int trace_print_context(struct trace_iterator *iter) 
			trace_seq_printf(s, "(%5d) ", tgid);

	}



	trace_seq_printf(s, "[%03d] ", iter->cpu);



	if (tr->trace_flags & TRACE_ITER_IRQ_INFO)

		trace_print_lat_fmt(s, entry);

CRA Git | Maintained and supported by SUSTech CRA and CCSE