Commit 35a7d804 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Jeff Kirsher
Browse files

i40e: Cleaning up missing null-terminate in conjunction with strncpy



Replacing strncpy with strlcpy to avoid strings that lacks null terminate.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Tested-By: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent f57e4fbd
Loading
Loading
Loading
Loading
+8 −8
Original line number Diff line number Diff line
@@ -4415,13 +4415,13 @@ static void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)

	switch (vsi->back->hw.phy.link_info.link_speed) {
	case I40E_LINK_SPEED_40GB:
		strncpy(speed, "40 Gbps", SPEED_SIZE);
		strlcpy(speed, "40 Gbps", SPEED_SIZE);
		break;
	case I40E_LINK_SPEED_10GB:
		strncpy(speed, "10 Gbps", SPEED_SIZE);
		strlcpy(speed, "10 Gbps", SPEED_SIZE);
		break;
	case I40E_LINK_SPEED_1GB:
		strncpy(speed, "1000 Mbps", SPEED_SIZE);
		strlcpy(speed, "1000 Mbps", SPEED_SIZE);
		break;
	default:
		break;
@@ -4429,16 +4429,16 @@ static void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)

	switch (vsi->back->hw.fc.current_mode) {
	case I40E_FC_FULL:
		strncpy(fc, "RX/TX", FC_SIZE);
		strlcpy(fc, "RX/TX", FC_SIZE);
		break;
	case I40E_FC_TX_PAUSE:
		strncpy(fc, "TX", FC_SIZE);
		strlcpy(fc, "TX", FC_SIZE);
		break;
	case I40E_FC_RX_PAUSE:
		strncpy(fc, "RX", FC_SIZE);
		strlcpy(fc, "RX", FC_SIZE);
		break;
	default:
		strncpy(fc, "None", FC_SIZE);
		strlcpy(fc, "None", FC_SIZE);
		break;
	}

@@ -5839,7 +5839,7 @@ static void i40e_send_version(struct i40e_pf *pf)
	dv.minor_version = DRV_VERSION_MINOR;
	dv.build_version = DRV_VERSION_BUILD;
	dv.subbuild_version = 0;
	strncpy(dv.driver_string, DRV_VERSION, sizeof(dv.driver_string));
	strlcpy(dv.driver_string, DRV_VERSION, sizeof(dv.driver_string));
	i40e_aq_send_driver_version(&pf->hw, &dv, NULL);
}