mtd: rawnand: sharpsl: Stop using nand_release() (35a37f91) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-50-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/sharpsl.c

+9 −3

Original line number	Diff line number	Diff line
		@@ -199,13 +199,19 @@ err_get_res:
		static int sharpsl_nand_remove(struct platform_device *pdev)
		{
		struct sharpsl_nand *sharpsl = platform_get_drvdata(pdev);
		struct nand_chip *chip = &sharpsl->chip;
		int ret;

		/* Release resources, unregister device */
		nand_release(&sharpsl->chip);
		/* Unregister device */
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);

		/* Release resources */
		nand_cleanup(chip);

		iounmap(sharpsl->io);

		/* Free the MTD device structure */
		/* Free the driver's structure */
		kfree(sharpsl);

		return 0;

Admin message