Commit 35872480 authored by Alexey Kardashevskiy's avatar Alexey Kardashevskiy Committed by Michael Ellerman
Browse files

powerpc/powernv/ioda: Split out TCE invalidation from TCE updates 



At the moment updates in a TCE table are made by iommu_table_ops::exchange
which update one TCE and invalidates an entry in the PHB/NPU TCE cache
via set of registers called "TCE Kill" (hence the naming).
Writing a TCE is a simple xchg() but invalidating the TCE cache is
a relatively expensive OPAL call. Mapping a 100GB guest with PCI+NPU
passed through devices takes about 20s.

Thankfully we can do better. Since such big mappings happen at the boot
time and when memory is plugged/onlined (i.e. not often), these requests
come in 512 pages so we call call OPAL 512 times less which brings 20s
from the above to less than 10s. Also, since TCE caches can be flushed
entirely, calling OPAL for 512 TCEs helps skiboot [1] to decide whether
to flush the entire cache or not.

This implements 2 new iommu_table_ops callbacks:
- xchg_no_kill() to update a single TCE with no TCE invalidation;
- tce_kill() to invalidate multiple TCEs.
This uses the same xchg_no_kill() callback for IODA1/2.

This implements 2 new wrappers on top of the new callbacks similar to
the existing iommu_tce_xchg().

This does not use the new callbacks yet, the next patches will;
so this should not cause any behavioral change.

Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190829085252.72370-2-aik@ozlabs.ru
parent 4f916593

arch/powerpc/include/asm/iommu.h

+17 −0
Original line number Diff line number Diff line
@@ -58,6 +58,17 @@ struct iommu_table_ops { 
			unsigned long *hpa,

			enum dma_data_direction *direction);



	int (*xchg_no_kill)(struct iommu_table *tbl,

			long index,

			unsigned long *hpa,

			enum dma_data_direction *direction,

			bool realmode);



	void (*tce_kill)(struct iommu_table *tbl,

			unsigned long index,

			unsigned long pages,

			bool realmode);



	__be64 *(*useraddrptr)(struct iommu_table *tbl, long index, bool alloc);

#endif

	void (*clear)(struct iommu_table *tbl,
@@ -206,6 +217,12 @@ extern void iommu_del_device(struct device *dev); 
extern long iommu_tce_xchg(struct mm_struct *mm, struct iommu_table *tbl,

		unsigned long entry, unsigned long *hpa,

		enum dma_data_direction *direction);

extern long iommu_tce_xchg_no_kill(struct mm_struct *mm,

		struct iommu_table *tbl,

		unsigned long entry, unsigned long *hpa,

		enum dma_data_direction *direction);

extern void iommu_tce_kill(struct iommu_table *tbl,

		unsigned long entry, unsigned long pages);

#else

static inline void iommu_register_group(struct iommu_table_group *table_group,

					int pci_domain_number,

arch/powerpc/kernel/iommu.c

+27 −0
Original line number Diff line number Diff line
@@ -1005,6 +1005,33 @@ long iommu_tce_xchg(struct mm_struct *mm, struct iommu_table *tbl, 
}

EXPORT_SYMBOL_GPL(iommu_tce_xchg);



extern long iommu_tce_xchg_no_kill(struct mm_struct *mm,

		struct iommu_table *tbl,

		unsigned long entry, unsigned long *hpa,

		enum dma_data_direction *direction)

{

	long ret;

	unsigned long size = 0;



	ret = tbl->it_ops->xchg_no_kill(tbl, entry, hpa, direction, false);

	if (!ret && ((*direction == DMA_FROM_DEVICE) ||

			(*direction == DMA_BIDIRECTIONAL)) &&

			!mm_iommu_is_devmem(mm, *hpa, tbl->it_page_shift,

					&size))

		SetPageDirty(pfn_to_page(*hpa >> PAGE_SHIFT));



	return ret;

}

EXPORT_SYMBOL_GPL(iommu_tce_xchg_no_kill);



void iommu_tce_kill(struct iommu_table *tbl,

		unsigned long entry, unsigned long pages)

{

	if (tbl->it_ops->tce_kill)

		tbl->it_ops->tce_kill(tbl, entry, pages, false);

}

EXPORT_SYMBOL_GPL(iommu_tce_kill);



int iommu_take_ownership(struct iommu_table *tbl)

{

	unsigned long flags, i, sz = (tbl->it_size + 7) >> 3;

arch/powerpc/platforms/powernv/pci-ioda.c

+12 −0
Original line number Diff line number Diff line
@@ -1939,6 +1939,14 @@ static int pnv_ioda1_tce_build(struct iommu_table *tbl, long index, 
}



#ifdef CONFIG_IOMMU_API

/* Common for IODA1 and IODA2 */

static int pnv_ioda_tce_xchg_no_kill(struct iommu_table *tbl, long index,

		unsigned long *hpa, enum dma_data_direction *direction,

		bool realmode)

{

	return pnv_tce_xchg(tbl, index, hpa, direction, !realmode);

}



static int pnv_ioda1_tce_xchg(struct iommu_table *tbl, long index,

		unsigned long *hpa, enum dma_data_direction *direction)

{
@@ -1975,6 +1983,8 @@ static struct iommu_table_ops pnv_ioda1_iommu_ops = { 
#ifdef CONFIG_IOMMU_API

	.exchange = pnv_ioda1_tce_xchg,

	.exchange_rm = pnv_ioda1_tce_xchg_rm,

	.xchg_no_kill = pnv_ioda_tce_xchg_no_kill,

	.tce_kill = pnv_pci_p7ioc_tce_invalidate,

	.useraddrptr = pnv_tce_useraddrptr,

#endif

	.clear = pnv_ioda1_tce_free,
@@ -2140,6 +2150,8 @@ static struct iommu_table_ops pnv_ioda2_iommu_ops = { 
#ifdef CONFIG_IOMMU_API

	.exchange = pnv_ioda2_tce_xchg,

	.exchange_rm = pnv_ioda2_tce_xchg_rm,

	.xchg_no_kill = pnv_ioda_tce_xchg_no_kill,

	.tce_kill = pnv_pci_ioda2_tce_invalidate,

	.useraddrptr = pnv_tce_useraddrptr,

#endif

	.clear = pnv_ioda2_tce_free,

CRA Git | Maintained and supported by SUSTech CRA and CCSE