Commit 35848e04 authored Oct 26, 2005 by Jeff Garzik Committed by Linus Torvalds Oct 26, 2005

[PATCH] kill massive wireless-related log spam



Although this message is having the intended effect of causing wireless
driver maintainers to upgrade their code, I never should have merged this
patch in its present form.  Leading to tons of bug reports and unhappy
users.

Some wireless apps poll for statistics regularly, which leads to a printk()
every single time they ask for stats.  That's a little bit _too_ much of a
reminder that the driver is using an old API.

Change this to printing out the message once, per kernel boot.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent bb320515

net/core/wireless.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -455,10 +455,15 @@ static inline struct iw_statistics get_wireless_stats(struct net_device dev)

		/* Old location, field to be removed in next WE */
		if(dev->get_wireless_stats) {
		static int printed_message;

		if (!printed_message++)
		printk(KERN_DEBUG "%s (WE) : Driver using old /proc/net/wireless support, please fix driver !\n",
		dev->name);

		return dev->get_wireless_stats(dev);
		}

		/* Not found */
		return (struct iw_statistics *) NULL;
		}

Admin message