Commit 357ae967 authored Oct 15, 2015 by sumit.saxena@avagotech.com Committed by Martin K. Petersen Oct 29, 2015

megaraid_sas: Do not use PAGE_SIZE for max_sectors



Do not use PAGE_SIZE marco to calculate max_sectors per I/O
request. Driver code assumes PAGE_SIZE will be always 4096 which can
lead to wrongly calculated value if PAGE_SIZE is not 4096. This issue
was reported in Ubuntu Bugzilla Bug #1475166.

Cc: <stable@vger.kernel.org>
Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 7364d34b

drivers/scsi/megaraid/megaraid_sas.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -388,6 +388,8 @@ enum MR_EVT_ARGS {
		MR_EVT_ARGS_GENERIC,
		};


		#define SGE_BUFFER_SIZE 4096
		/*
		* define constants for device list query options
		*/

drivers/scsi/megaraid/megaraid_sas_base.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4871,7 +4871,7 @@ static int megasas_init_fw(struct megasas_instance *instance)


		instance->max_sectors_per_req = instance->max_num_sge *
		PAGE_SIZE / 512;
		SGE_BUFFER_SIZE / 512;
		if (tmp_sectors && (instance->max_sectors_per_req > tmp_sectors))
		instance->max_sectors_per_req = tmp_sectors;

Admin message