Commit 357768cc authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Maarten Lankhorst
Browse files

drm/edid: Fix cea mode aspect ratio handling 



commit 6dffd431 ("drm: Add aspect ratio parsing in DRM layer")
cause us to not send out any VICs in the AVI infoframes. That commit
was since reverted, but if and when we add aspect ratio handing back
we need to be more careful.

Let's handle this by considering the aspect ratio as a requirement
for cea mode matching only if the passed in mode actually has a
non-zero aspect ratio field. This will keep userspace that doesn't
provide an aspect ratio working as before by matching it to the
first otherwise equal cea mode. And once userspace starts to
provide the aspect ratio it will be considerd a hard requirement
for the match.

Also change the hdmi mode matching to use drm_mode_match() for
consistency, but we don't match on aspect ratio there since the
spec doesn't list a specific aspect ratio for those modes.

Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: "Lin, Jia" <lin.a.jia@intel.com>
Cc: Akashdeep Sharma <akashdeep.sharma@intel.com>
Cc: Jim Bride <jim.bride@linux.intel.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarShashank Sharma <shashank.sharma@intel.com>
Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1525777785-9740-4-git-send-email-ankit.k.nautiyal@intel.com
parent a2328fd6

drivers/gpu/drm/drm_edid.c

+14 −4
Original line number Diff line number Diff line
@@ -2930,11 +2930,15 @@ cea_mode_alternate_timings(u8 vic, struct drm_display_mode *mode) 
static u8 drm_match_cea_mode_clock_tolerance(const struct drm_display_mode *to_match,

					     unsigned int clock_tolerance)

{

	unsigned int match_flags = DRM_MODE_MATCH_TIMINGS | DRM_MODE_MATCH_FLAGS;

	u8 vic;



	if (!to_match->clock)

		return 0;



	if (to_match->picture_aspect_ratio)

		match_flags |= DRM_MODE_MATCH_ASPECT_RATIO;



	for (vic = 1; vic < ARRAY_SIZE(edid_cea_modes); vic++) {

		struct drm_display_mode cea_mode = edid_cea_modes[vic];

		unsigned int clock1, clock2;
@@ -2948,7 +2952,7 @@ static u8 drm_match_cea_mode_clock_tolerance(const struct drm_display_mode *to_m 
			continue;



		do {

			if (drm_mode_equal_no_clocks_no_stereo(to_match, &cea_mode))

			if (drm_mode_match(to_match, &cea_mode, match_flags))

				return vic;

		} while (cea_mode_alternate_timings(vic, &cea_mode));

	}
@@ -2965,11 +2969,15 @@ static u8 drm_match_cea_mode_clock_tolerance(const struct drm_display_mode *to_m 
 */

u8 drm_match_cea_mode(const struct drm_display_mode *to_match)

{

	unsigned int match_flags = DRM_MODE_MATCH_TIMINGS | DRM_MODE_MATCH_FLAGS;

	u8 vic;



	if (!to_match->clock)

		return 0;



	if (to_match->picture_aspect_ratio)

		match_flags |= DRM_MODE_MATCH_ASPECT_RATIO;



	for (vic = 1; vic < ARRAY_SIZE(edid_cea_modes); vic++) {

		struct drm_display_mode cea_mode = edid_cea_modes[vic];

		unsigned int clock1, clock2;
@@ -2983,7 +2991,7 @@ u8 drm_match_cea_mode(const struct drm_display_mode *to_match) 
			continue;



		do {

			if (drm_mode_equal_no_clocks_no_stereo(to_match, &cea_mode))

			if (drm_mode_match(to_match, &cea_mode, match_flags))

				return vic;

		} while (cea_mode_alternate_timings(vic, &cea_mode));

	}
@@ -3030,6 +3038,7 @@ hdmi_mode_alternate_clock(const struct drm_display_mode *hdmi_mode) 
static u8 drm_match_hdmi_mode_clock_tolerance(const struct drm_display_mode *to_match,

					      unsigned int clock_tolerance)

{

	unsigned int match_flags = DRM_MODE_MATCH_TIMINGS | DRM_MODE_MATCH_FLAGS;

	u8 vic;



	if (!to_match->clock)
@@ -3047,7 +3056,7 @@ static u8 drm_match_hdmi_mode_clock_tolerance(const struct drm_display_mode *to_ 
		    abs(to_match->clock - clock2) > clock_tolerance)

			continue;



		if (drm_mode_equal_no_clocks_no_stereo(to_match, hdmi_mode))

		if (drm_mode_match(to_match, hdmi_mode, match_flags))

			return vic;

	}
@@ -3064,6 +3073,7 @@ static u8 drm_match_hdmi_mode_clock_tolerance(const struct drm_display_mode *to_ 
 */

static u8 drm_match_hdmi_mode(const struct drm_display_mode *to_match)

{

	unsigned int match_flags = DRM_MODE_MATCH_TIMINGS | DRM_MODE_MATCH_FLAGS;

	u8 vic;



	if (!to_match->clock)
@@ -3079,7 +3089,7 @@ static u8 drm_match_hdmi_mode(const struct drm_display_mode *to_match) 


		if ((KHZ2PICOS(to_match->clock) == KHZ2PICOS(clock1) ||

		     KHZ2PICOS(to_match->clock) == KHZ2PICOS(clock2)) &&

		    drm_mode_equal_no_clocks_no_stereo(to_match, hdmi_mode))

		    drm_mode_match(to_match, hdmi_mode, match_flags))

			return vic;

	}

	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE