Commit 355cced4 authored Mar 15, 2016 by Christoph Hellwig Committed by Dave Chinner Mar 15, 2016

xfs: always set rvalp in xfs_dir2_node_trim_free



xfs_dir2_node_trim_free can return with setting the rvalp argument
pointer.  Initialize it to 0 at the beginning of the function and
only update it to 1 if we succeeded trimming a freespace block.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent cc07eed8

fs/xfs/libxfs/xfs_dir2_node.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2235,6 +2235,9 @@ xfs_dir2_node_trim_free(

		dp = args->dp;
		tp = args->trans;

		*rvalp = 0;

		/*
		* Read the freespace block.
		*/
		@@ -2255,7 +2258,6 @@ xfs_dir2_node_trim_free(
		*/
		if (freehdr.nused > 0) {
		xfs_trans_brelse(tp, bp);
		*rvalp = 0;
		return 0;
		}
		/*

Admin message