Commit 354cf003 authored May 10, 2019 by Hans Verkuil Committed by Mauro Carvalho Chehab May 22, 2019

media: cec: mark devnode as registered before actually registering it



The cec device node can be used right after it was created, but that
leaves a race condition where the device was created, but devnode->registered
was still false. So an ioctl() would result in an error.

So set it to true before calling cdev_device_add() and to false again if
cdev_device_add returned an error.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 9390467c

drivers/media/cec/cec-core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -128,13 +128,14 @@ static int __must_check cec_devnode_register(struct cec_devnode *devnode,
		devnode->cdev.owner = owner;
		kobject_set_name(&devnode->cdev.kobj, "cec%d", devnode->minor);

		devnode->registered = true;
		ret = cdev_device_add(&devnode->cdev, &devnode->dev);
		if (ret) {
		devnode->registered = false;
		pr_err("%s: cdev_device_add failed\n", __func__);
		goto clr_bit;
		}

		devnode->registered = true;
		return 0;

		clr_bit:

Admin message