Commit 35455e23 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by David S. Miller
Browse files

devlink: Add health dump {get,clear} commands 



Add devlink health dump commands, in order to run an dump operation
over a specific reporter.

The supported operations are dump_get in order to get last saved
dump (if not exist, dump now) and dump_clear to clear last saved
dump.

It is expected from driver's callback for diagnose command to fill it
via the devlink fmsg API. Devlink will parse it and convert it to
netlink nla API in order to pass it to the user.

Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fca42a27

include/uapi/linux/devlink.h

+2 −0
Original line number Diff line number Diff line
@@ -100,6 +100,8 @@ enum devlink_command { 
	DEVLINK_CMD_HEALTH_REPORTER_SET,

	DEVLINK_CMD_HEALTH_REPORTER_RECOVER,

	DEVLINK_CMD_HEALTH_REPORTER_DIAGNOSE,

	DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET,

	DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,



	/* add new commands above here */

	__DEVLINK_CMD_MAX,

net/core/devlink.c

+63 −0
Original line number Diff line number Diff line
@@ -4791,6 +4791,53 @@ out: 
	return err;

}



static int devlink_nl_cmd_health_reporter_dump_get_doit(struct sk_buff *skb,

							struct genl_info *info)

{

	struct devlink *devlink = info->user_ptr[0];

	struct devlink_health_reporter *reporter;

	int err;



	reporter = devlink_health_reporter_get_from_info(devlink, info);

	if (!reporter)

		return -EINVAL;



	if (!reporter->ops->dump)

		return -EOPNOTSUPP;



	mutex_lock(&reporter->dump_lock);

	err = devlink_health_do_dump(reporter, NULL);

	if (err)

		goto out;



	err = devlink_fmsg_snd(reporter->dump_fmsg, info,

			       DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET, 0);



out:

	mutex_unlock(&reporter->dump_lock);

	return err;

}



static int

devlink_nl_cmd_health_reporter_dump_clear_doit(struct sk_buff *skb,

					       struct genl_info *info)

{

	struct devlink *devlink = info->user_ptr[0];

	struct devlink_health_reporter *reporter;



	reporter = devlink_health_reporter_get_from_info(devlink, info);

	if (!reporter)

		return -EINVAL;



	if (!reporter->ops->dump)

		return -EOPNOTSUPP;



	mutex_lock(&reporter->dump_lock);

	devlink_health_dump_clear(reporter);

	mutex_unlock(&reporter->dump_lock);

	return 0;

}



static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = {

	[DEVLINK_ATTR_BUS_NAME] = { .type = NLA_NUL_STRING },

	[DEVLINK_ATTR_DEV_NAME] = { .type = NLA_NUL_STRING },
@@ -5091,6 +5138,22 @@ static const struct genl_ops devlink_nl_ops[] = { 
		.flags = GENL_ADMIN_PERM,

		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK,

	},

	{

		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET,

		.doit = devlink_nl_cmd_health_reporter_dump_get_doit,

		.policy = devlink_nl_policy,

		.flags = GENL_ADMIN_PERM,

		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK |

				  DEVLINK_NL_FLAG_NO_LOCK,

	},

	{

		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,

		.doit = devlink_nl_cmd_health_reporter_dump_clear_doit,

		.policy = devlink_nl_policy,

		.flags = GENL_ADMIN_PERM,

		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK |

				  DEVLINK_NL_FLAG_NO_LOCK,

	},

};



static struct genl_family devlink_nl_family __ro_after_init = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE