Commit 352e512c authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller
Browse files

[NET]: Eliminate duplicate copies of dst_discard 



We have a number of copies of dst_discard scattered around the place
which all do the same thing, namely free a packet on the input or
output paths.

This patch deletes all of them except dst_discard and points all the
users to it.

The only non-trivial bit is decnet where it returns an error.
However, conceptually this is identical to the blackhole functions
used in IPv4 and IPv6 which do not return errors.  So they should
either all return errors or all return zero.  For now I've stuck with
the majority and picked zero as the return value.

It doesn't really matter in practice since few if any driver would
react differently depending on a zero return value or NET_RX_DROP.

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b4ce9277

include/net/dst.h

+1 −0
Original line number Diff line number Diff line
@@ -179,6 +179,7 @@ static inline struct dst_entry *dst_pop(struct dst_entry *dst) 
	return child;

}



extern int dst_discard(struct sk_buff *skb);

extern void * dst_alloc(struct dst_ops * ops);

extern void __dst_free(struct dst_entry * dst);

extern struct dst_entry *dst_destroy(struct dst_entry * dst);

net/core/dst.c

+2 −1
Original line number Diff line number Diff line
@@ -153,11 +153,12 @@ loop: 
#endif

}



static int dst_discard(struct sk_buff *skb)

int dst_discard(struct sk_buff *skb)

{

	kfree_skb(skb);

	return 0;

}

EXPORT_SYMBOL(dst_discard);



void * dst_alloc(struct dst_ops * ops)

{

net/decnet/dn_route.c

+1 −12
Original line number Diff line number Diff line
@@ -764,17 +764,6 @@ drop: 
	return NET_RX_DROP;

}



/*

 * Drop packet. This is used for endnodes and for

 * when we should not be forwarding packets from

 * this dest.

 */

static int dn_blackhole(struct sk_buff *skb)

{

	kfree_skb(skb);

	return NET_RX_DROP;

}



/*

 * Used to catch bugs. This should never normally get

 * called.
@@ -1396,7 +1385,7 @@ make_route: 
		default:

		case RTN_UNREACHABLE:

		case RTN_BLACKHOLE:

			rt->u.dst.input = dn_blackhole;

			rt->u.dst.input = dst_discard;

	}

	rt->rt_flags = flags;

	if (rt->u.dst.dev)

net/ipv4/route.c

+3 −8
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ 
#include <linux/jhash.h>

#include <linux/rcupdate.h>

#include <linux/times.h>

#include <net/dst.h>

#include <net/net_namespace.h>

#include <net/protocol.h>

#include <net/ip.h>
@@ -2357,12 +2358,6 @@ static struct dst_ops ipv4_dst_blackhole_ops = { 
};





static int ipv4_blackhole_output(struct sk_buff *skb)

{

	kfree_skb(skb);

	return 0;

}



static int ipv4_dst_blackhole(struct rtable **rp, struct flowi *flp, struct sock *sk)

{

	struct rtable *ort = *rp;
@@ -2374,8 +2369,8 @@ static int ipv4_dst_blackhole(struct rtable **rp, struct flowi *flp, struct sock 


		atomic_set(&new->__refcnt, 1);

		new->__use = 1;

		new->input = ipv4_blackhole_output;

		new->output = ipv4_blackhole_output;

		new->input = dst_discard;

		new->output = dst_discard;

		memcpy(new->metrics, ort->u.dst.metrics, RTAX_MAX*sizeof(u32));



		new->dev = ort->u.dst.dev;

net/ipv6/exthdrs.c

+2 −11
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
#include <linux/in6.h>

#include <linux/icmpv6.h>



#include <net/dst.h>

#include <net/sock.h>

#include <net/snmp.h>
@@ -318,18 +319,8 @@ void __init ipv6_destopt_init(void) 
		printk(KERN_ERR "ipv6_destopt_init: Could not register protocol\n");

}



/********************************

  NONE header. No data in packet.

 ********************************/



static int ipv6_nodata_rcv(struct sk_buff *skb)

{

	kfree_skb(skb);

	return 0;

}



static struct inet6_protocol nodata_protocol = {

	.handler	=	ipv6_nodata_rcv,

	.handler	=	dst_discard,

	.flags		=	INET6_PROTO_NOPOLICY,

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE