Commit 351d74e4 authored Apr 27, 2017 by Arnd Bergmann Committed by Mark Brown Apr 30, 2017

ASoC: Intel: Skylake: fix uninitialized pointer use

The error handling in bxt_sst_dsp_init() got changed in a way that
it now derefences an uninitialized pointer when printing a warning
about the device not being found:

sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized]

As we do have a valid device pointer available at the call site,
let's use that instead.

Fixes: 9fe9c711 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent b6726009

sound/soc/intel/skylake/bxt-sst.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device dev, void __iomem mmio_base, int irq,

		ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
		if (ret < 0) {
		dev_err(skl->dev, "%s: no device\n", __func__);
		dev_err(dev, "%s: no device\n", __func__);
		return ret;
		}

Admin message