Commit 350c9f48 authored Feb 21, 2018 by Eric Dumazet Committed by David S. Miller Feb 22, 2018

tcp_bbr: better deal with suboptimal GSO



BBR uses tcp_tso_autosize() in an attempt to probe what would be the
burst sizes and to adjust cwnd in bbr_target_cwnd() with following
gold formula :

/* Allow enough full-sized skbs in flight to utilize end systems. */
cwnd += 3 * bbr->tso_segs_goal;

But GSO can be lacking or be constrained to very small
units (ip link set dev ... gso_max_segs 2)

What we really want is to have enough packets in flight so that both
GSO and GRO are efficient.

So in the case GSO is off or downgraded, we still want to have the same
number of packets in flight as if GSO/TSO was fully operational, so
that GRO can hopefully be working efficiently.

To fix this issue, we make tcp_tso_autosize() unaware of
sk->sk_gso_max_segs

Only tcp_tso_segs() has to enforce the gso_max_segs limit.

Tested:

ethtool -K eth0 tso off gso off
tc qd replace dev eth0 root pfifo_fast

Before patch:
for f in {1..5}; do ./super_netperf 1 -H lpaa24 -- -K bbr; done
    691  (ss -temoi shows cwnd is stuck around 6 )
    667
    651
    631
    517

After patch :
# for f in {1..5}; do ./super_netperf 1 -H lpaa24 -- -K bbr; done
   1733 (ss -temoi shows cwnd is around 386 )
   1778
   1746
   1781
   1718

Fixes: 0f8782ea ("tcp_bbr: add BBR congestion control")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 88e80c62

net/ipv4/tcp_output.c

+5 −4

Original line number	Original line	Diff line number	Diff line
	@@ -1730,7 +1730,7 @@ u32 tcp_tso_autosize(const struct sock *sk, unsigned int mss_now,
	*/		*/
	segs = max_t(u32, bytes / mss_now, min_tso_segs);		segs = max_t(u32, bytes / mss_now, min_tso_segs);

	return min_t(u32, segs, sk->sk_gso_max_segs);		return segs;
	}		}
	EXPORT_SYMBOL(tcp_tso_autosize);		EXPORT_SYMBOL(tcp_tso_autosize);

	@@ -1742,9 +1742,10 @@ static u32 tcp_tso_segs(struct sock *sk, unsigned int mss_now)
	const struct tcp_congestion_ops *ca_ops = inet_csk(sk)->icsk_ca_ops;		const struct tcp_congestion_ops *ca_ops = inet_csk(sk)->icsk_ca_ops;
	u32 tso_segs = ca_ops->tso_segs_goal ? ca_ops->tso_segs_goal(sk) : 0;		u32 tso_segs = ca_ops->tso_segs_goal ? ca_ops->tso_segs_goal(sk) : 0;

	return tso_segs ? :		if (!tso_segs)
	tcp_tso_autosize(sk, mss_now,		tso_segs = tcp_tso_autosize(sk, mss_now,
	sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs);		sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs);
			return min_t(u32, tso_segs, sk->sk_gso_max_segs);
	}		}

	/* Returns the portion of skb which can be sent right away */		/* Returns the portion of skb which can be sent right away */

Admin message