Commit 34ffabe3 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Remove 'prefault_disable' modparam 



The 'prefault_disable' modparam was used by IGT to prevent a few
prefaulting operations to make fault handling under struct_mutex more
prominent. With the removal of struct_mutex, this is not as important
any more and we have almost completely stopped using the parameter. The
remaining use in execbuf is now immaterial and can be dropped without
affecting coverage.

We must re-address the idea of fault injection though.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200124230656.687503-1-chris@chris-wilson.co.uk
parent 7e36505d

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

+0 −3
Original line number Diff line number Diff line
@@ -1646,9 +1646,6 @@ static int eb_prefault_relocations(const struct i915_execbuffer *eb) 
	const unsigned int count = eb->buffer_count;

	unsigned int i;



	if (unlikely(i915_modparams.prefault_disable))

		return 0;



	for (i = 0; i < count; i++) {

		int err;

drivers/gpu/drm/i915/i915_params.c

+0 −4
Original line number Diff line number Diff line
@@ -103,10 +103,6 @@ i915_param_named(fastboot, int, 0600, 
	"(0=disabled, 1=enabled) "

	"Default: -1 (use per-chip default)");



i915_param_named_unsafe(prefault_disable, bool, 0600,

	"Disable page prefaulting for pread/pwrite/reloc (default:false). "

	"For developers only.");



i915_param_named_unsafe(load_detect_test, bool, 0600,

	"Force-enable the VGA load detect code for testing (default:false). "

	"For developers only.");

drivers/gpu/drm/i915/i915_params.h

+0 −1
Original line number Diff line number Diff line
@@ -71,7 +71,6 @@ struct drm_printer; 
	param(unsigned long, fake_lmem_start, 0, 0400) \

	/* leave bools at the end to not create holes */ \

	param(bool, enable_hangcheck, true, 0600) \

	param(bool, prefault_disable, false, 0600) \

	param(bool, load_detect_test, false, 0600) \

	param(bool, force_reset_modeset_test, false, 0600) \

	param(bool, error_capture, true, 0600) \

CRA Git | Maintained and supported by SUSTech CRA and CCSE