fbdev: sysfs files can't disappear before the device is gone (34f31f14) · Commits · 戴 / test

Which means lock_fb_info can never fail. Remove the error handling. Signed-off-by:

Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Rob Clark <robdclark@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-14-daniel.vetter@ffwll.ch

drivers/video/fbdev/core/fbsysfs.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -175,10 +175,7 @@ static ssize_t store_modes(struct device *device,
		return -EINVAL;

		console_lock();
		if (!lock_fb_info(fb_info)) {
		console_unlock();
		return -ENODEV;
		}
		lock_fb_info(fb_info);

		list_splice(&fb_info->modelist, &old_list);
		fb_videomode_to_modelist((const struct fb_videomode *)buf, i,
		@@ -405,10 +402,7 @@ static ssize_t store_fbstate(struct device *device,
		state = simple_strtoul(buf, &last, 0);

		console_lock();
		if (!lock_fb_info(fb_info)) {
		console_unlock();
		return -ENODEV;
		}
		lock_fb_info(fb_info);

		fb_set_suspend(fb_info, (int)state);