Commit 34ec4366 authored Apr 01, 2014 by Alexander Usyskin Committed by Greg Kroah-Hartman Apr 16, 2014

mei: ignore client writing state during cb completion



Ignore client writing state during cb completion to fix a memory
leak.

When moving cbs to the completion list we should not look at
writing_state as this state can be already overwritten by next
write, the fact that a cb is on the write waiting list means
that it was already written to the HW and we can safely complete it.

Same pays for wait in poll handler, we do not have to check the state
wake is done after completion list processing.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5e6533a6

drivers/misc/mei/interrupt.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -455,8 +455,7 @@ int mei_irq_write_handler(struct mei_device dev, struct mei_cl_cb cmpl_list)

		cl->status = 0;
		list_del(&cb->list);
		if (MEI_WRITING == cl->writing_state &&
		cb->fop_type == MEI_FOP_WRITE &&
		if (cb->fop_type == MEI_FOP_WRITE &&
		cl != &dev->iamthif_cl) {
		cl_dbg(dev, cl, "MEI WRITE COMPLETE\n");
		cl->writing_state = MEI_WRITE_COMPLETE;

drivers/misc/mei/main.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -644,7 +644,6 @@ static unsigned int mei_poll(struct file file, poll_table wait)
		goto out;
		}

		if (MEI_WRITE_COMPLETE == cl->writing_state)
		mask \|= (POLLIN \| POLLRDNORM);

		out:

Admin message