Commit 34debdca authored Dec 19, 2019 by Will Deacon Committed by Joerg Roedel Dec 23, 2019

iommu/arm-smmu: Prevent forced unbinding of Arm SMMU drivers

Forcefully unbinding the Arm SMMU drivers is a pretty dangerous operation,
since it will likely lead to catastrophic failure for any DMA devices
mastering through the SMMU being unbound. When the driver then attempts
to "handle" the fatal faults, it's very easy to trip over dead data
structures, leading to use-after-free.

On John's machine, he reports that the machine was "unusable" due to
loss of the storage controller following a forced unbind of the SMMUv3
driver:

  | # cd ./bus/platform/drivers/arm-smmu-v3
  | # echo arm-smmu-v3.0.auto > unbind
  | hisi_sas_v2_hw HISI0162:01: CQE_AXI_W_ERR (0x800) found!
  | platform arm-smmu-v3.0.auto: CMD_SYNC timeout at 0x00000146
  | [hwprod 0x00000146, hwcons 0x00000000]

Prevent this forced unbinding of the drivers by setting "suppress_bind_attrs"
to true.

Link: https://lore.kernel.org/lkml/06dfd385-1af0-3106-4cc5-6a5b8e864759@huawei.com


Reported-by: John Garry <john.garry@huawei.com>
Signed-off-by: Will Deacon <will@kernel.org>
Tested-by: John Garry <john.garry@huawei.com> # smmu v3
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent b06c076e

drivers/iommu/arm-smmu-v3.c

+3 −2

Original line number	Original line	Diff line number	Diff line
	@@ -3702,6 +3702,7 @@ static struct platform_driver arm_smmu_driver = {
	.driver = {		.driver = {
	.name = "arm-smmu-v3",		.name = "arm-smmu-v3",
	.of_match_table = of_match_ptr(arm_smmu_of_match),		.of_match_table = of_match_ptr(arm_smmu_of_match),
			.suppress_bind_attrs = true,
	},		},
	.probe = arm_smmu_device_probe,		.probe = arm_smmu_device_probe,
	.remove = arm_smmu_device_remove,		.remove = arm_smmu_device_remove,

drivers/iommu/arm-smmu.c

+4 −3

Original line number	Original line	Diff line number	Diff line
	@@ -2271,6 +2271,7 @@ static struct platform_driver arm_smmu_driver = {
	.name = "arm-smmu",		.name = "arm-smmu",
	.of_match_table = of_match_ptr(arm_smmu_of_match),		.of_match_table = of_match_ptr(arm_smmu_of_match),
	.pm = &arm_smmu_pm_ops,		.pm = &arm_smmu_pm_ops,
			.suppress_bind_attrs = true,
	},		},
	.probe = arm_smmu_device_probe,		.probe = arm_smmu_device_probe,
	.remove = arm_smmu_device_remove,		.remove = arm_smmu_device_remove,

Admin message