Commit 34d1b089 authored Nov 11, 2019 by Jean-Philippe Brucker Committed by Joerg Roedel Nov 11, 2019

iommu/arm-smmu: Remove duplicate error message

Since commit 7723f4c5 ("driver core: platform: Add an error message
to platform_get_irq*()"), platform_get_irq() displays an error when the
IRQ isn't found. Remove the error print from the SMMU driver. Note the
slight change of behaviour: no message is printed if platform_get_irq()
returns -EPROBE_DEFER, which probably doesn't concern the SMMU.

Fixes: 7723f4c5 ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent f7aff1a9

drivers/iommu/arm-smmu.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2095,10 +2095,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
		for (i = 0; i < num_irqs; ++i) {
		int irq = platform_get_irq(pdev, i);

		if (irq < 0) {
		dev_err(dev, "failed to get irq index %d\n", i);
		if (irq < 0)
		return -ENODEV;
		}
		smmu->irqs[i] = irq;
		}

Admin message