Commit 34c1c21e authored Nov 17, 2016 by Sudeep Holla Committed by Ulf Hansson Nov 29, 2016

soc: fsl: fix section mismatch build warnings



We get the following warning with the driver is compiled in:

WARNING: modpost: Found 1 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'

With CONFIG_DEBUG_SECTION_MISMATCH enabled, the details are reported:

WARNING: vmlinux.o(.text+0x55d014): Section mismatch in reference from the
function fsl_guts_probe() to the function
.init.text:of_flat_dt_get_machine_name()
The function fsl_guts_probe() references
the function __init of_flat_dt_get_machine_name().
This is often because fsl_guts_probe lacks a __init
annotation or the annotation of of_flat_dt_get_machine_name is wrong.

This patch fixes the issue by using the normal DT/OF API rather than
the of_flat_* one.

Cc: Scott Wood <oss@buserror.net>
Cc: Yangbo Lu <yangbo.lu@nxp.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 151ede40

drivers/soc/fsl/guts.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -132,7 +132,7 @@ EXPORT_SYMBOL(fsl_guts_get_svr);

		static int fsl_guts_probe(struct platform_device *pdev)
		{
		struct device_node *np = pdev->dev.of_node;
		struct device_node root, np = pdev->dev.of_node;
		struct device *dev = &pdev->dev;
		struct resource *res;
		const struct fsl_soc_die_attr *soc_die;
		@@ -152,7 +152,10 @@ static int fsl_guts_probe(struct platform_device *pdev)
		return PTR_ERR(guts->regs);

		/* Register soc device */
		machine = of_flat_dt_get_machine_name();
		root = of_find_node_by_path("/");
		if (of_property_read_string(root, "model", &machine))
		of_property_read_string_index(root, "compatible", 0, &machine);
		of_node_put(root);
		if (machine)
		soc_dev_attr.machine = devm_kstrdup(dev, machine, GFP_KERNEL);

Admin message