scsi: megaraid_sas: Remove spin lock for dpc operation (34bd9f27) · Commits · 戴 / test

Optimization: No need to hold hba_lock in dpc context for reading atomic variable. Signed-off-by:

drivers/scsi/megaraid/megaraid_sas_fusion.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -3573,18 +3573,13 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)
		{
		struct megasas_instance *instance =
		(struct megasas_instance *)instance_addr;
		unsigned long flags;
		u32 count, MSIxIndex;

		count = instance->msix_vectors > 0 ? instance->msix_vectors : 1;

		/* If we have already declared adapter dead, donot complete cmds */
		spin_lock_irqsave(&instance->hba_lock, flags);
		if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR) {
		spin_unlock_irqrestore(&instance->hba_lock, flags);
		if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR)
		return;
		}
		spin_unlock_irqrestore(&instance->hba_lock, flags);

		for (MSIxIndex = 0 ; MSIxIndex < count; MSIxIndex++)
		complete_cmd_fusion(instance, MSIxIndex);