Commit 34b0dadb authored May 18, 2017 by Radim Krčmář

KVM: x86/vPMU: fix undefined shift in intel_pmu_refresh()



Static analysis noticed that pmu->nr_arch_gp_counters can be 32
(INTEL_PMC_MAX_GENERIC) and therefore cannot be used to shift 'int'.

I didn't add BUILD_BUG_ON for it as we have a better checker.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 25462f7f ("KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch")
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent f0367ee1

arch/x86/kvm/pmu_intel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -294,7 +294,7 @@ static void intel_pmu_refresh(struct kvm_vcpu *vcpu)
		((u64)1 << edx.split.bit_width_fixed) - 1;
		}

		pmu->global_ctrl = ((1 << pmu->nr_arch_gp_counters) - 1) \|
		pmu->global_ctrl = ((1ull << pmu->nr_arch_gp_counters) - 1) \|
		(((1ull << pmu->nr_arch_fixed_counters) - 1) << INTEL_PMC_IDX_FIXED);
		pmu->global_ctrl_mask = ~pmu->global_ctrl;

Admin message