Commit 34aa7994 authored Mar 11, 2020 by Jules Irenge Committed by Takashi Iwai Mar 11, 2020

ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue()



Sparse reports a warning at tscm_hwdep_read_queue()

warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock

The root cause is the missing annotation at tscm_hwdep_read_queue()
Add the missing __releases(&tscm->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20200311010908.42366-8-jbi.octave@gmail.com


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 3bbf9e2f

sound/firewire/tascam/tascam-hwdep.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -36,6 +36,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm tscm, char __user buf,

		static long tscm_hwdep_read_queue(struct snd_tscm tscm, char __user buf,
		long remained, loff_t *offset)
		__releases(&tscm->lock)
		{
		char __user *pos = buf;
		unsigned int type = SNDRV_FIREWIRE_EVENT_TASCAM_CONTROL;

Admin message