staging: rts5208: Rewrite redundant if statement to improve code style (34a49d9e) · Commits · 戴 / test

This commit uses the fact that if (a) { if (b) { ... } } can instead be written as if (a && b) { ... } without any change in behavior, allowing to decrease the indentation of the contained code block and thus reducing the average line length. Signed-off-by:

Tobias Nießen <tobias.niessen@stud.uni-hannover.de> Signed-off-by:

Sabrina Gaube <sabrina-gaube@web.de> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rts5208/sd.c

+11 −12

Original line number	Diff line number	Diff line
		@@ -4507,8 +4507,8 @@ int sd_execute_write_data(struct scsi_cmnd srb, struct rtsx_chip chip)
		sd_lock_state, sd_card->sd_lock_status);
		if (sd_lock_state ^ (sd_card->sd_lock_status & SD_LOCKED)) {
		sd_card->sd_lock_notify = 1;
		if (sd_lock_state) {
		if (sd_card->sd_lock_status & SD_LOCK_1BIT_MODE) {
		if (sd_lock_state &&
		(sd_card->sd_lock_status & SD_LOCK_1BIT_MODE)) {
		sd_card->sd_lock_status \|= (
		SD_UNLOCK_POW_ON \| SD_SDR_RST);
		if (CHK_SD(sd_card)) {
		@@ -4523,7 +4523,6 @@ int sd_execute_write_data(struct scsi_cmnd srb, struct rtsx_chip chip)
		}
		}
		}
		}

		if (lock_cmd_fail) {
		scsi_set_resid(srb, 0);

Admin message