Commit 3469b573 authored Dec 06, 2009 by Erez Zadok Committed by Tyler Hicks Jan 19, 2010

ecryptfs: pass matching flags to interpose as defined and used there



ecryptfs_interpose checks if one of the flags passed is
ECRYPTFS_INTERPOSE_FLAG_D_ADD, defined as 0x00000001 in ecryptfs_kernel.h.
But the only user of ecryptfs_interpose to pass a non-zero flag to it, has
hard-coded the value as "1". This could spell trouble if any of these values
changes in the future.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Dustin Kirkland <kirkland@canonical.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>

parent c44a66d6

fs/ecryptfs/inode.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -282,7 +282,8 @@ int ecryptfs_lookup_and_interpose_lower(struct dentry *ecryptfs_dentry,
		goto out;
		}
		rc = ecryptfs_interpose(lower_dentry, ecryptfs_dentry,
		ecryptfs_dir_inode->i_sb, 1);
		ecryptfs_dir_inode->i_sb,
		ECRYPTFS_INTERPOSE_FLAG_D_ADD);
		if (rc) {
		printk(KERN_ERR "%s: Error interposing; rc = [%d]\n",
		__func__, rc);

Admin message