Commit 343c3d7f authored Apr 06, 2020 by Mateusz Nosek Committed by Linus Torvalds Apr 07, 2020

mm/shmem.c: clean code by removing unnecessary assignment



Previously 0 was assigned to variable 'error' but the variable was never
read before reassignemnt later.  So the assignment can be removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Hugh Dickins <hughd@google.com>
Link: http://lkml.kernel.org/r/20200301152832.24595-1-mateusznosek0@gmail.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 27d80fa2

mm/shmem.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -3120,13 +3120,10 @@ static int shmem_symlink(struct inode dir, struct dentry dentry, const char *s

		error = security_inode_init_security(inode, dir, &dentry->d_name,
		shmem_initxattrs, NULL);
		if (error) {
		if (error != -EOPNOTSUPP) {
		if (error && error != -EOPNOTSUPP) {
		iput(inode);
		return error;
		}
		error = 0;
		}

		inode->i_size = len-1;
		if (len <= SHORT_SYMLINK_LEN) {

Admin message