Commit 342ffc26 authored Jun 23, 2017 by Seth Forshee Committed by Martin K. Petersen Jun 26, 2017

scsi: aacraid: Don't copy uninitialized stack memory to userspace

Both aac_send_raw_srb() and aac_get_hba_info() may copy stack allocated
structs to userspace without initializing all members of these
structs. Clear out this memory to prevent information leaks.

Fixes: 423400e6 ("scsi: aacraid: Include HBA direct interface")
Fixes: c799d519 ("scsi: aacraid: Retrieve HBA host information ioctl")
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 1d32a62c

drivers/scsi/aacraid/commctrl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -949,6 +949,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
		&((struct aac_native_hba *)srbfib->hw_fib_va)->resp.err;
		struct aac_srb_reply reply;

		memset(&reply, 0, sizeof(reply));
		reply.status = ST_OK;
		if (srbfib->flags & FIB_CONTEXT_FLAG_FASTRESP) {
		/* fast response */
		@@ -1020,6 +1021,7 @@ static int aac_get_hba_info(struct aac_dev dev, void __user arg)
		{
		struct aac_hba_info hbainfo;

		memset(&hbainfo, 0, sizeof(hbainfo));
		hbainfo.adapter_number = (u8) dev->id;
		hbainfo.system_io_bus_number = dev->pdev->bus->number;
		hbainfo.device_number = (dev->pdev->devfn >> 3);