Commit 342ed240 authored May 27, 2020 by Zhang Qiang Committed by Tejun Heo May 27, 2020

workqueue: Remove unnecessary kfree() call in rcu_free_wq()

The data structure member "wq->rescuer" was reset to a null pointer
in one if branch. It was passed to a call of the function "kfree"
in the callback function "rcu_free_wq" (which was eventually executed).
The function "kfree" does not perform more meaningful data processing
for a passed null pointer (besides immediately returning from such a call).
Thus delete this function call which became unnecessary with the referenced
software update.

Fixes: def98c84 ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

Suggested-by: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent b92b36ea

kernel/workqueue.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
		else
		free_workqueue_attrs(wq->unbound_attrs);

		kfree(wq->rescuer);
		kfree(wq);
		}

Admin message