irqchip/gic-v3: Remove acknowledge loop (342677d7) · Commits · 戴 / test

Multiple interrupts pending for a CPU is actually rare. Doing an acknowledge loop does not give much better performance or even can deteriorate them. Do not loop when an interrupt has been acknowledged, just return from interrupt and wait for another one to be raised. Tested-by:

Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by:

Julien Thierry <julien.thierry@arm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by:

Marc Zyngier <marc.zyngier@arm.com>

drivers/irqchip/irq-gic-v3.c

+31 −34

Original line number	Diff line number	Diff line
		@@ -348,7 +348,6 @@ static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs
		{
		u32 irqnr;

		do {
		irqnr = gic_read_iar();

		if (likely(irqnr > 15 && irqnr < 1020) \|\| irqnr >= 8192) {
		@@ -369,7 +368,7 @@ static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs
		gic_write_eoir(irqnr);
		}
		}
		continue;
		return;
		}
		if (irqnr < 16) {
		gic_write_eoir(irqnr);
		@@ -387,9 +386,7 @@ static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs
		#else
		WARN_ONCE(true, "Unexpected SGI received!\n");
		#endif
		continue;
		}
		} while (irqnr != ICC_IAR1_EL1_SPURIOUS);
		}

		static void __init gic_dist_init(void)

Admin message