Commit 341ee434 authored Dec 16, 2011 by Dan Carpenter Committed by John W. Linville Dec 19, 2011

NFC: double unlock in nfc_llcp_recv_connect()



We unlock inside the if block on the other side of this if else
statement.  It could result in calling mutex_unlock() twice.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent bad69194

net/nfc/llcp/llcp.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -554,10 +554,8 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
		goto enqueue;
		}
		}

		}

		mutex_unlock(&local->socket_lock);
		}

		reason = LLCP_DM_NOBOUND;
		goto fail;

Admin message