Commit 340049d4 authored Nov 18, 2019 by Chuhong Yuan Committed by Vinod Koul Nov 22, 2019

dmaengine: ti: edma: fix missed failure handling



When devm_kcalloc fails, it forgets to call edma_free_slot.
Replace direct return with failure handler to fix it.

Fixes: 1be5336b ("dmaengine: edma: New device tree binding")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191118073802.28424-1-hslester96@gmail.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 39716c56

drivers/dma/ti/edma.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2424,8 +2424,10 @@ static int edma_probe(struct platform_device *pdev)

		ecc->tc_list = devm_kcalloc(dev, ecc->num_tc,
		sizeof(*ecc->tc_list), GFP_KERNEL);
		if (!ecc->tc_list)
		return -ENOMEM;
		if (!ecc->tc_list) {
		ret = -ENOMEM;
		goto err_reg1;
		}

		for (i = 0;; i++) {
		ret = of_parse_phandle_with_fixed_args(node, "ti,tptcs",

Admin message