Commit 33fcc549 authored Oct 21, 2020 by Gustavo Pimentel Committed by Greg Kroah-Hartman Nov 03, 2020

misc: pci_endpoint_test: Remove unnecessary verification

The first condition of the if statement can never be true, because
bar variable is an enum variable type defined between 0 and 5, and
also bar variable acquires the value from arg function parameter which
is an unsigned long variable.

The constant 5 was replaced the the equivalent enum type, in this case
BAR_5.

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/142cbbc215bed4243a219ea17b46f4256ceccb22.1603315690.git.gustavo.pimentel@synopsys.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f0f753da

drivers/misc/pci_endpoint_test.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -708,7 +708,7 @@ static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd,
		switch (cmd) {
		case PCITEST_BAR:
		bar = arg;
		if (bar < 0 \|\| bar > 5)
		if (bar > BAR_5)
		goto ret;
		if (is_am654_pci_dev(pdev) && bar == BAR_0)
		goto ret;