Commit 33f18c96 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

net: ethernet: don't set phylib state CHANGELINK in drivers 



After phy_start() phylib takes care of all needed actions, including
aneg settings and checking link state. There's no need to set state
PHY_CHANGELINK in drivers.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 624b66f8

drivers/net/ethernet/amd/au1000_eth.c

+1 −4
Original line number Original line Diff line number Diff line
@@ -940,11 +940,8 @@ static int au1000_open(struct net_device *dev) 
		return retval;

		return retval;

	}

	}





	if (dev->phydev) {

	if (dev->phydev)

		/* cause the PHY state machine to schedule a link state check */

		dev->phydev->state = PHY_CHANGELINK;

		phy_start(dev->phydev);

		phy_start(dev->phydev);

	}





	netif_start_queue(dev);

	netif_start_queue(dev);

drivers/net/ethernet/ti/cpmac.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -991,7 +991,6 @@ static int cpmac_open(struct net_device *dev) 
	cpmac_hw_start(dev);

	cpmac_hw_start(dev);





	napi_enable(&priv->napi);

	napi_enable(&priv->napi);

	dev->phydev->state = PHY_CHANGELINK;

	phy_start(dev->phydev);

	phy_start(dev->phydev);





	return 0;

	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE