Commit 33ebffa1 authored Aug 24, 2020 by Peter Ujfalusi Committed by Vinod Koul Aug 25, 2020

dmaengine: ti: k3-udma: Fix the TR initialization for prep_slave_sg



The TR which needs to be initialized for the next sg entry is indexed by
tr_idx and not by the running i counter.

In case any sub element in the SG needs more than one TR, the code would
corrupt an already configured TR.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200824120108.9178-1-peter.ujfalusi@ti.com


Fixes: 6cf668a4 ("dmaengine: ti: k3-udma: Use the TR counter helper for slave_sg and cyclic")
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 0661cef6

drivers/dma/ti/k3-udma.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2059,9 +2059,9 @@ udma_prep_slave_sg_tr(struct udma_chan uc, struct scatterlist sgl,
		return NULL;
		}

		cppi5_tr_init(&tr_req[i].flags, CPPI5_TR_TYPE1, false, false,
		CPPI5_TR_EVENT_SIZE_COMPLETION, 0);
		cppi5_tr_csf_set(&tr_req[i].flags, CPPI5_TR_CSF_SUPR_EVT);
		cppi5_tr_init(&tr_req[tr_idx].flags, CPPI5_TR_TYPE1, false,
		false, CPPI5_TR_EVENT_SIZE_COMPLETION, 0);
		cppi5_tr_csf_set(&tr_req[tr_idx].flags, CPPI5_TR_CSF_SUPR_EVT);

		tr_req[tr_idx].addr = sg_addr;
		tr_req[tr_idx].icnt0 = tr0_cnt0;

Admin message