Commit 33cf601d authored Jun 15, 2020 by Ka-Cheong Poon Committed by David S. Miller Jun 15, 2020

net/rds: NULL pointer de-reference in rds_ib_add_one()



The parent field of a struct device may be NULL.  The macro
ibdev_to_node() should check for that.

Signed-off-by: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b3a9e3b9

net/rds/ib.h

+7 −1

Original line number	Diff line number	Diff line
		@@ -264,7 +264,13 @@ struct rds_ib_device {
		int *vector_load;
		};

		#define ibdev_to_node(ibdev) dev_to_node((ibdev)->dev.parent)
		static inline int ibdev_to_node(struct ib_device *ibdev)
		{
		struct device *parent;

		parent = ibdev->dev.parent;
		return parent ? dev_to_node(parent) : NUMA_NO_NODE;
		}
		#define rdsibdev_to_node(rdsibdev) ibdev_to_node(rdsibdev->dev)

		/* bits for i_ack_flags */

Admin message