Commit 33c2b803 authored Jul 17, 2017 by Tom Lendacky Committed by Ingo Molnar Jul 18, 2017

x86/mm: Remove phys_to_virt() usage in ioremap()



Currently there is a check if the address being mapped is in the ISA
range (is_ISA_range()), and if it is, then phys_to_virt() is used to
perform the mapping. When SME is active, the default is to add pagetable
mappings with the encryption bit set unless specifically overridden. The
resulting pagetable mapping from phys_to_virt() will result in a mapping
that has the encryption bit set. With SME, the use of ioremap() is
intended to generate pagetable mappings that do not have the encryption
bit set through the use of the PAGE_KERNEL_IO protection value.

Rather than special case the SME scenario, remove the ISA range check and
usage of phys_to_virt() and have ISA range mappings continue through the
remaining ioremap() path.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Larry Woodman <lwoodman@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Toshimitsu Kani <toshi.kani@hpe.com>
Cc: kasan-dev@googlegroups.com
Cc: kvm@vger.kernel.org
Cc: linux-arch@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/88ada7b09c6568c61cd696351eb59fb15a82ce1a.1500319216.git.thomas.lendacky@amd.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 7744ccdb

arch/x86/mm/ioremap.c

+8 −10

Original line number	Diff line number	Diff line
		@@ -105,12 +105,6 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr,
		return NULL;
		}

		/*
		* Don't remap the low PCI/ISA area, it's always mapped..
		*/
		if (is_ISA_range(phys_addr, last_addr))
		return (__force void __iomem *)phys_to_virt(phys_addr);

		/*
		* Don't allow anybody to remap normal RAM that we're using..
		*/
		@@ -340,13 +334,17 @@ void iounmap(volatile void __iomem *addr)
		return;

		/*
		* __ioremap special-cases the PCI/ISA range by not instantiating a
		* vm_area and by simply returning an address into the kernel mapping
		* of ISA space. So handle that here.
		* The PCI/ISA range special-casing was removed from __ioremap()
		* so this check, in theory, can be removed. However, there are
		* cases where iounmap() is called for addresses not obtained via
		* ioremap() (vga16fb for example). Add a warning so that these
		* cases can be caught and fixed.
		*/
		if ((void __force *)addr >= phys_to_virt(ISA_START_ADDRESS) &&
		(void __force *)addr < phys_to_virt(ISA_END_ADDRESS))
		(void __force *)addr < phys_to_virt(ISA_END_ADDRESS)) {
		WARN(1, "iounmap() called for ISA range not obtained using ioremap()\n");
		return;
		}

		addr = (volatile void __iomem *)
		(PAGE_MASK & (unsigned long __force)addr);

Admin message