media: atomisp: relax firmware version detection criteria (33c24f8f) · Commits · 戴 / test

As getting the exact version used by the driver is not easy, let's relax the version detection and hope for the best, producing just a warning. Signed-off-by:

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

drivers/staging/media/atomisp/pci/sh_css_firmware.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -196,13 +196,13 @@ sh_css_check_firmware_version(struct device dev, const char fw_data)
		file_header = &firmware_header->file_header;

		if (strcmp(file_header->version, release_version) != 0) {
		dev_err(dev, "Fw version check failed. Expecting '%s', firmware is '%s'.\n",
		dev_err(dev, "Firmware version may not be compatible with this driver\n");
		dev_err(dev, "Expecting version '%s', but firmware is '%s'.\n",
		release_version, file_header->version);
		return false;
		} else {
		/* firmware version matches */
		return true;
		}

		/* For now, let's just accept a wrong version, even if wrong */
		return true;
		}

		enum ia_css_err

Admin message