Commit 33a1060a authored Jul 17, 2007 by J. Bruce Fields Committed by Linus Torvalds Jul 17, 2007

knfsd: nfsd4: fix NFSv4 filehandle size units confusion



NFS4_FHSIZE is measured in bytes, not 4-byte words, so much more space than
necessary is being allocated for struct nfs4_cb_recall.

I should have wondered why this structure was so much larger than it needed to
be!

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9a8db97e

include/linux/nfsd/state.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,7 @@ struct nfs4_cb_recall {
		int cbr_trunc;
		stateid_t cbr_stateid;
		u32 cbr_fhlen;
		u32 cbr_fhval[NFS4_FHSIZE];
		char cbr_fhval[NFS4_FHSIZE];
		struct nfs4_delegation *cbr_dp;
		};

Admin message