Commit 331ca0f8 authored Feb 07, 2020 by Miaohe Lin Committed by Paolo Bonzini Feb 12, 2020

KVM: apic: reuse smp_wmb() in kvm_make_request()



kvm_make_request() provides smp_wmb() so pending_events changes are
guaranteed to be visible.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 20796447

arch/x86/kvm/lapic.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1080,9 +1080,6 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
		result = 1;
		/* assumes that there are only KVM_APIC_INIT/SIPI */
		apic->pending_events = (1UL << KVM_APIC_INIT);
		/* make sure pending_events is visible before sending
		* the request */
		smp_wmb();
		kvm_make_request(KVM_REQ_EVENT, vcpu);
		kvm_vcpu_kick(vcpu);
		}

Admin message