Commit 331c7372 authored by Dejin Zheng's avatar Dejin Zheng Committed by David S. Miller
Browse files

net: phy: bcm84881: use phy_read_mmd_poll_timeout() to simplify the code



use phy_read_mmd_poll_timeout() to replace the poll codes for
simplify bcm84881_wait_init() function.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bd971ff0
Loading
Loading
Loading
Loading
+4 −23
Original line number Diff line number Diff line
@@ -22,30 +22,11 @@ enum {

static int bcm84881_wait_init(struct phy_device *phydev)
{
	unsigned int tries = 20;
	int ret, val;
	int val;

	do {
		val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL1);
		if (val < 0) {
			ret = val;
			break;
		}
		if (!(val & MDIO_CTRL1_RESET)) {
			ret = 0;
			break;
		}
		if (!--tries) {
			ret = -ETIMEDOUT;
			break;
		}
		msleep(100);
	} while (1);

	if (ret)
		phydev_err(phydev, "%s failed: %d\n", __func__, ret);

	return ret;
	return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL1,
					 val, !(val & MDIO_CTRL1_RESET),
					 100000, 2000000, false);
}

static int bcm84881_config_init(struct phy_device *phydev)