Commit 330ed4da authored Mar 22, 2016 by Franck Jullien Committed by Vinod Koul Apr 05, 2016

dmaengine: vdma: don't crash when bad channel is requested

When client request a non existing channel from of_dma_xilinx_xlate
we get a NULL pointer dereferencing. This patch fix this problem.

Signed-off-by: Franck Jullien <franck.jullien@odyssee-systemes.fr>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent f55532a0

drivers/dma/xilinx/xilinx_vdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1236,7 +1236,7 @@ static struct dma_chan of_dma_xilinx_xlate(struct of_phandle_args dma_spec,
		struct xilinx_vdma_device *xdev = ofdma->of_dma_data;
		int chan_id = dma_spec->args[0];

		if (chan_id >= XILINX_VDMA_MAX_CHANS_PER_DEVICE)
		if (chan_id >= XILINX_VDMA_MAX_CHANS_PER_DEVICE \|\| !xdev->chan[chan_id])
		return NULL;

		return dma_get_slave_channel(&xdev->chan[chan_id]->common);