Commit 32e9072b authored May 19, 2012 by David S. Miller

ipx: Remove spurious NULL checking in ipx_ioctl().



We already unconditionally dereference 'sk' via lock_sock(sk) earlier
in this function, and our caller (sock_do_ioctl()) makes takes similar
liberties.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 72e843bb

net/ipx/af_ipx.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1901,8 +1901,6 @@ static int ipx_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
		(const unsigned short __user *)argp);
		break;
		case SIOCGSTAMP:
		rc = -EINVAL;
		if (sk)
		rc = sock_get_timestamp(sk, argp);
		break;
		case SIOCGIFDSTADDR:

Admin message