Commit 32e6deb2 authored by Bruce Allan's avatar Bruce Allan Committed by Tony Nguyen
Browse files

ice: cleanup misleading comment 



The maximum Admin Queue buffer size and NVM shadow RAM sector size are both
4 Kilobytes. Some comments refer to those as 4Kb which can be confused with
4 Kilobits. Update the comments to use the commonly used KB symbol instead.

Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent bcf68ea1

drivers/net/ethernet/intel/ice/ice_nvm.c

+3 −3
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ ice_aq_read_nvm(struct ice_hw *hw, u16 module_typeid, u32 offset, u16 length, 
 *

 * Reads a portion of the NVM, as a flat memory space. This function correctly

 * breaks read requests across Shadow RAM sectors and ensures that no single

 * read request exceeds the maximum 4Kb read for a single AdminQ command.

 * read request exceeds the maximum 4KB read for a single AdminQ command.

 *

 * Returns a status code on failure. Note that the data pointer may be

 * partially updated if some reads succeed before a failure.
@@ -81,10 +81,10 @@ ice_read_flat_nvm(struct ice_hw *hw, u32 offset, u32 *length, u8 *data, 
	do {

		u32 read_size, sector_offset;



		/* ice_aq_read_nvm cannot read more than 4Kb at a time.

		/* ice_aq_read_nvm cannot read more than 4KB at a time.

		 * Additionally, a read from the Shadow RAM may not cross over

		 * a sector boundary. Conveniently, the sector size is also

		 * 4Kb.

		 * 4KB.

		 */

		sector_offset = offset % ICE_AQ_MAX_BUF_LEN;

		read_size = min_t(u32, ICE_AQ_MAX_BUF_LEN - sector_offset,

CRA Git | Maintained and supported by SUSTech CRA and CCSE