Commit 32d75141 authored Mar 31, 2017 by Russell King Committed by David S. Miller Apr 01, 2017

net: phy: allow EEE with any interface mode



EEE is able to work in any PHY interface mode, there is nothing which
fundamentally restricts it to only a few modes.  For example, EEE works
in SGMII mode with the Marvell 88E1512.

Rather than just adding SGMII mode to the list, Florian suggests
removing the list of interface modes entirely:

  It actually sounds like we should just kill the check entirely,
  it does not appear that any of the interface mode would not
  fundamentally be able to support EEE, because the "lowest" mode
  we support is MII, and even there it's quite possible to support
  EEE.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f75abeb8

drivers/net/phy/phy.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -1208,15 +1208,8 @@ int phy_init_eee(struct phy_device *phydev, bool clk_stop_enable)
		return -EIO;

		/* According to 802.3az,the EEE is supported only in full duplex-mode.
		* Also EEE feature is active when core is operating with MII, GMII
		* or RGMII (all kinds). Internal PHYs are also allowed to proceed and
		* should return an error if they do not support EEE.
		*/
		if ((phydev->duplex == DUPLEX_FULL) &&
		((phydev->interface == PHY_INTERFACE_MODE_MII) \|\|
		(phydev->interface == PHY_INTERFACE_MODE_GMII) \|\|
		phy_interface_is_rgmii(phydev) \|\|
		phy_is_internal(phydev))) {
		if (phydev->duplex == DUPLEX_FULL) {
		int eee_lp, eee_cap, eee_adv;
		u32 lp, cap, adv;
		int status;

Admin message