Commit 32ca98fe authored Mar 16, 2020 by Petr Machata Committed by David S. Miller Mar 16, 2020

net: ip_gre: Accept IFLA_INFO_DATA-less configuration



The fix referenced below causes a crash when an ERSPAN tunnel is created
without passing IFLA_INFO_DATA. Fix by validating passed-in data in the
same way as ipgre does.

Fixes: e1f8f78f ("net: ip_gre: Separate ERSPAN newlink / changelink callbacks")
Reported-by:  <syzbot+1b4ebf4dae4e510dd219@syzkaller.appspotmail.com>
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 065fd83e

net/ipv4/ip_gre.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1168,6 +1168,8 @@ static int erspan_netlink_parms(struct net_device *dev,
		err = ipgre_netlink_parms(dev, data, tb, parms, fwmark);
		if (err)
		return err;
		if (!data)
		return 0;

		if (data[IFLA_GRE_ERSPAN_VER]) {
		t->erspan_ver = nla_get_u8(data[IFLA_GRE_ERSPAN_VER]);

Admin message