Commit 3285170f authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Walleij
Browse files

gpiolib: Fix references to gpiod_[gs]et_*value_cansleep() variants 



Commit 372e722e ("gpiolib: use descriptors internally") renamed
the functions to use a "gpiod" prefix, and commit 79a9becd
("gpiolib: export descriptor-based GPIO interface") introduced the "raw"
variants, but both changes forgot to update the comments.

Readd a similar reference to gpiod_set_value(), which was accidentally
removed by commit 1e77fc82 ("gpio: Add missing open drain/source
handling to gpiod_set_value_cansleep()").

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20190701142738.25219-1-geert+renesas@glider.be


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent f99d479b

drivers/gpio/gpiolib.c

+4 −3
Original line number Diff line number Diff line
@@ -3037,7 +3037,7 @@ int gpiod_get_array_value_complex(bool raw, bool can_sleep, 
int gpiod_get_raw_value(const struct gpio_desc *desc)

{

	VALIDATE_DESC(desc);

	/* Should be using gpio_get_value_cansleep() */

	/* Should be using gpiod_get_raw_value_cansleep() */

	WARN_ON(desc->gdev->chip->can_sleep);

	return gpiod_get_raw_value_commit(desc);

}
@@ -3058,7 +3058,7 @@ int gpiod_get_value(const struct gpio_desc *desc) 
	int value;



	VALIDATE_DESC(desc);

	/* Should be using gpio_get_value_cansleep() */

	/* Should be using gpiod_get_value_cansleep() */

	WARN_ON(desc->gdev->chip->can_sleep);



	value = gpiod_get_raw_value_commit(desc);
@@ -3329,7 +3329,7 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep, 
void gpiod_set_raw_value(struct gpio_desc *desc, int value)

{

	VALIDATE_DESC_VOID(desc);

	/* Should be using gpiod_set_value_cansleep() */

	/* Should be using gpiod_set_raw_value_cansleep() */

	WARN_ON(desc->gdev->chip->can_sleep);

	gpiod_set_raw_value_commit(desc, value);

}
@@ -3370,6 +3370,7 @@ static void gpiod_set_value_nocheck(struct gpio_desc *desc, int value) 
void gpiod_set_value(struct gpio_desc *desc, int value)

{

	VALIDATE_DESC_VOID(desc);

	/* Should be using gpiod_set_value_cansleep() */

	WARN_ON(desc->gdev->chip->can_sleep);

	gpiod_set_value_nocheck(desc, value);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE