Commit 327cdeda authored Feb 15, 2014 by Julia Lawall Committed by David S. Miller Feb 17, 2014

caif: delete unnecessary field initialization

On success, the function netdev_alloc_skb initializes the dev field of its
result to its first argument, so this doesn't have to be done in the
calling context.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression skb,privn,e;
@@

skb = netdev_alloc_skb(privn,...);
... when strict
(
-skb->dev = privn;
|
?skb = e
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d94b27c8

drivers/net/caif/caif_serial.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -204,7 +204,6 @@ static void ldisc_receive(struct tty_struct tty, const u8 data,

		skb->protocol = htons(ETH_P_CAIF);
		skb_reset_mac_header(skb);
		skb->dev = ser->dev;
		debugfs_rx(ser, data, count);
		/* Push received packet up the stack. */
		ret = netif_rx_ni(skb);

drivers/net/caif/caif_spi.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -554,7 +554,6 @@ int cfspi_rxfrm(struct cfspi cfspi, u8 buf, size_t len)

		skb->protocol = htons(ETH_P_CAIF);
		skb_reset_mac_header(skb);
		skb->dev = cfspi->ndev;

		/*
		* Push received packet up the stack.

Admin message