ASoC: cx20442: remove incorerct __exit markups (32556394) · Commits · 戴 / test

Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by:

Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/codecs/cx20442.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -420,7 +420,7 @@ static int cx20442_platform_probe(struct platform_device *pdev)
		&cx20442_codec_dev, &cx20442_dai, 1);
		}

		static int __exit cx20442_platform_remove(struct platform_device *pdev)
		static int cx20442_platform_remove(struct platform_device *pdev)
		{
		snd_soc_unregister_codec(&pdev->dev);
		return 0;
		@@ -431,7 +431,7 @@ static struct platform_driver cx20442_platform_driver = {
		.name = "cx20442-codec",
		},
		.probe = cx20442_platform_probe,
		.remove = __exit_p(cx20442_platform_remove),
		.remove = cx20442_platform_remove,
		};

		module_platform_driver(cx20442_platform_driver);

Admin message