Commit 323a391a authored Dec 04, 2020 by Oliver Hartkopp Committed by Jakub Kicinski Dec 09, 2020

can: isotp: isotp_setsockopt(): block setsockopt on bound sockets



The isotp socket can be widely configured in its behaviour regarding addressing
types, fill-ups, receive pattern tests and link layer length. Usually all
these settings need to be fixed before bind() and can not be changed
afterwards.

This patch adds a check to enforce the common usage pattern.

Fixes: e057dd3f ("can: add ISO 15765-2:2016 transport protocol")
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tested-by: Thomas Wagner <thwa1@web.de>
Link: https://lore.kernel.org/r/20201203140604.25488-2-socketcan@hartkopp.net


Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://lore.kernel.org/r/20201204133508.742120-3-mkl@pengutronix.de


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 72d05c00

net/can/isotp.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1157,6 +1157,9 @@ static int isotp_setsockopt(struct socket *sock, int level, int optname,
		if (level != SOL_CAN_ISOTP)
		return -EINVAL;

		if (so->bound)
		return -EISCONN;

		switch (optname) {
		case CAN_ISOTP_OPTS:
		if (optlen != sizeof(struct can_isotp_options))

Admin message