Commit 32388d6e authored Oct 10, 2018 by Sakari Ailus Committed by Mauro Carvalho Chehab Nov 06, 2018

media: ipu3-cio2: Unregister device nodes first, then release resources



While there are issues related to object lifetime management, unregister
the media device first, followed immediately by other device nodes when
the driver is being unbound. Only then the resources needed by the driver
may be released. This is slightly safer.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Bingbu Cao <bingbu.cao@intel.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 30efae3d

drivers/media/pci/intel/ipu3/ipu3-cio2.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1846,12 +1846,12 @@ static void cio2_pci_remove(struct pci_dev *pci_dev)
		struct cio2_device *cio2 = pci_get_drvdata(pci_dev);
		unsigned int i;

		media_device_unregister(&cio2->media_dev);
		cio2_notifier_exit(cio2);
		cio2_fbpt_exit_dummy(cio2);
		for (i = 0; i < CIO2_QUEUES; i++)
		cio2_queue_exit(cio2, &cio2->queue[i]);
		cio2_fbpt_exit_dummy(cio2);
		v4l2_device_unregister(&cio2->v4l2_dev);
		media_device_unregister(&cio2->media_dev);
		media_device_cleanup(&cio2->media_dev);
		mutex_destroy(&cio2->lock);
		}

Admin message