Commit 3220fb66 authored Jul 07, 2020 by Jesper Dangaard Brouer Committed by Daniel Borkmann Jul 09, 2020

selftests/bpf: test_progs use another shell exit on non-actions



This is a follow up adjustment to commit 6c92bd5c ("selftests/bpf:
Test_progs indicate to shell on non-actions"), that returns shell exit
indication EXIT_FAILURE (value 1) when user selects a non-existing test.

The problem with using EXIT_FAILURE is that a shell script cannot tell
the difference between a non-existing test and the test failing.

This patch uses value 2 as shell exit indication.
(Aside note unrecognized option parameters use value 64).

Fixes: 6c92bd5c ("selftests/bpf: Test_progs indicate to shell on non-actions")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/159410593992.1093222.90072558386094370.stgit@firesoul

parent 625eb8e8

tools/testing/selftests/bpf/test_progs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -12,6 +12,8 @@
		#include <string.h>
		#include <execinfo.h> /* backtrace */

		#define EXIT_NO_TEST 2

		/* defined in test_progs.h */
		struct test_env env = {};

		@@ -740,7 +742,7 @@ out:
		close(env.saved_netns_fd);

		if (env.succ_cnt + env.fail_cnt + env.skip_cnt == 0)
		return EXIT_FAILURE;
		return EXIT_NO_TEST;

		return env.fail_cnt ? EXIT_FAILURE : EXIT_SUCCESS;
		}

Admin message